[Fix accessibility] severity 4 Issues #1352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpg619
commented
Nov 6, 2024
| {children} | ||
| <PageFooter /> | ||
| </Container> | ||
| <TableOfContents.Desktop /> |
There was a problem hiding this comment.
keyboard focus order from left to right
jpg619
requested review from
leobalter,
monishcm and
wraithgar
as code owners
wraithgar
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
This pull request includes a few changes to the
src/components/site-title.jsandsrc/layout.jsfiles to improve the layout and structure of the components.Layout improvements:
src/layout.js: Reordered theTableOfContents.Desktopcomponent to be placed after theContainercomponent and removed theflexDirection: 'row-reverse'style. [1] [2]Code cleanup:
src/components/site-title.js: Removed the redundantrole="banner"attribute from theBoxcomponent.BEFORE & AFTER